jlxq0/caldav-mcp
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages 1 Wiki Activity Actions

docs(agents): record the two-sided guard pitfall #6

Merged
jlxq0 merged 2 commits from docs-two-sided-guard into main 2026-08-26 04:52:39 +00:00
Conversation 0 Commits 2 Files changed 1 +7
jlxq0 commented 2026-08-25 02:28:55 +00:00
Owner
Copy link

Documentation only.

#5 added the assertion; this records why it was missing. A guard written as a != x || b != x is two conditions, and a test exercising one side leaves the other deletable with the suite still green. In loopback_matches_ignoring_port the unpinned side was the allowlist entry's scheme: dropping it port-relaxes an https://localhost:8443/callback entry (loopback host) into a cleartext http://localhost:3118/callback, an https to http downgrade on an entry the operator wrote expecting TLS.

Follow-up to #2 and #5. No code change, no release.

Documentation only. #5 added the assertion; this records why it was missing. A guard written as `a != x || b != x` is two conditions, and a test exercising one side leaves the other deletable with the suite still green. In `loopback_matches_ignoring_port` the unpinned side was the allowlist entry's scheme: dropping it port-relaxes an `https://localhost:8443/callback` entry (loopback host) into a cleartext `http://localhost:3118/callback`, an https to http downgrade on an entry the operator wrote expecting TLS. Follow-up to #2 and #5. No code change, no release.
docs(agents): record the two-sided guard pitfall
Some checks failed
CI / cargo (pull_request) Failing after 2s
Details
CI / docker (pull_request) Has been skipped
Details
6c76564144
 
A guard written as `a != x || b != x` is two conditions. A test that
exercises one side leaves the other deletable with the suite green, which
is how the entry-scheme half of `loopback_matches_ignoring_port` went
unpinned until #5.
ci: re-trigger after runner volume expansion
All checks were successful
CI / cargo (pull_request) Successful in 49s
Details
CI / docker (pull_request) Successful in 56s
Details
ed81912f4b
 
The 02:28 cargo job failed after 2s on a runner with no disk. cargo fmt,
clippy -D warnings and the 100-test suite are green locally on this tree.
jlxq0 merged commit 983b2a1e8b into main 2026-08-26 04:52:39 +00:00
jlxq0 deleted branch docs-two-sided-guard 2026-08-26 04:52:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked
Held on something external and named in the body: an issue, a credential, a measurement. Not the same as unreviewed.

  
waiting-on-julian
Blocked on Julian. The ask is in the issue.

No labels
blocked
waiting-on-julian
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jlxq0/caldav-mcp!6
No description provided.